nix: Alias the openssl3 binary #4252
Closed
+1
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lrstewart
reviewed
Oct 18, 2023
Comment on lines
+100
to
101
| alias openssl3=${openssl_3_0}/bin/openssl | ||
| export PS1="[nix $S2N_LIBCRYPTO] $PS1" |
There was a problem hiding this comment.
Should we print some message saying this alias is available? It was the first command I tried when I wanted openssl-3, but idk if that's a universal thought :)
There was a problem hiding this comment.
Maybe print both the commands and the outputs of "openssl version" and "openssl3 version". Maybe every shell should do that?
|
This PR has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
|
closing in favor of #4422 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolved issues:
none
Description of changes:
In nix, we need the openssl binary in the path 'pinned' to version 1.1.1, but sometimes we'd like to be able to use the libcrypto that we picked as part of the build environment. Add an alias based on the full nix path to openssl3.
Call-outs:
Do we need this for everything else ? awslc=bsdsl, openssl102, etc...
Testing:
How is this change tested (unit tests, fuzz tests, etc.)? locally
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.